refactor Python API to be more pythonic - part 2 #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmuhs
force-pushed
the
deprecate-old-methods
branch
from
fa239f2 to
9201557
Compare
narekgharibyan
approved these changes
Feb 14, 2025
Member
narekgharibyan
left a comment
narekgharibyan
left a comment
There was a problem hiding this comment.
lgtm, added 2 minor comments/questions.
|
|
||
|
|
||
| def GetCompletions(self, *args): | ||
| return call_deprecated_method("GetCompletions", "complete", self.complete, *args) |
Member
There was a problem hiding this comment.
isn't get_completions better ?
Contributor
Author
There was a problem hiding this comment.
🤔
In a previous change I named it like this:
- complete_prefix
- complete_multiword
- complete_fuzzy
avoiding prefixes like get_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #267, it changes more API's to be more consistent with naming in python. The old naming is still possible, but causes a deprecation message.